2016-02-20 15:53:20 -06:00
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
RSpec.describe Status, type: :model do
|
2016-02-26 08:28:08 -06:00
|
|
|
let(:alice) { Fabricate(:account, username: 'alice') }
|
|
|
|
let(:bob) { Fabricate(:account, username: 'bob') }
|
2017-07-28 17:06:29 -05:00
|
|
|
let(:other) { Fabricate(:status, account: bob, text: 'Skulls for the skull god! The enemy\'s gates are sideways!') }
|
2016-02-26 08:28:08 -06:00
|
|
|
|
|
|
|
subject { Fabricate(:status, account: alice) }
|
|
|
|
|
2016-02-24 17:17:01 -06:00
|
|
|
describe '#local?' do
|
2016-02-26 08:28:08 -06:00
|
|
|
it 'returns true when no remote URI is set' do
|
|
|
|
expect(subject.local?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false if a remote URI is set' do
|
2017-09-06 12:01:28 -05:00
|
|
|
alice.update(domain: 'example.com')
|
|
|
|
subject.save
|
2016-02-26 08:28:08 -06:00
|
|
|
expect(subject.local?).to be false
|
|
|
|
end
|
2017-09-06 12:01:28 -05:00
|
|
|
|
|
|
|
it 'returns true if a URI is set and `local` is true' do
|
|
|
|
subject.update(uri: 'example.com', local: true)
|
|
|
|
expect(subject.local?).to be true
|
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#reblog?' do
|
2016-02-26 08:28:08 -06:00
|
|
|
it 'returns true when the status reblogs another status' do
|
|
|
|
subject.reblog = other
|
|
|
|
expect(subject.reblog?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false if the status is self-contained' do
|
|
|
|
expect(subject.reblog?).to be false
|
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#reply?' do
|
2016-02-26 08:28:08 -06:00
|
|
|
it 'returns true if the status references another' do
|
|
|
|
subject.thread = other
|
|
|
|
expect(subject.reply?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false if the status is self-contained' do
|
|
|
|
expect(subject.reply?).to be false
|
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#verb' do
|
2017-11-16 00:46:29 -06:00
|
|
|
context 'if destroyed?' do
|
|
|
|
it 'returns :delete' do
|
|
|
|
subject.destroy!
|
|
|
|
expect(subject.verb).to be :delete
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'unless destroyed?' do
|
|
|
|
context 'if reblog?' do
|
|
|
|
it 'returns :share' do
|
|
|
|
subject.reblog = other
|
|
|
|
expect(subject.verb).to be :share
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'unless reblog?' do
|
|
|
|
it 'returns :post' do
|
|
|
|
subject.reblog = nil
|
|
|
|
expect(subject.verb).to be :post
|
|
|
|
end
|
|
|
|
end
|
2016-02-26 08:28:08 -06:00
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#object_type' do
|
2016-02-26 08:28:08 -06:00
|
|
|
it 'is note when the status is self-contained' do
|
|
|
|
expect(subject.object_type).to be :note
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is comment when the status replies to another' do
|
|
|
|
subject.thread = other
|
|
|
|
expect(subject.object_type).to be :comment
|
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
|
|
|
|
2017-11-15 20:07:27 -06:00
|
|
|
describe '#hidden?' do
|
|
|
|
context 'if private_visibility?' do
|
|
|
|
it 'returns true' do
|
|
|
|
subject.visibility = :private
|
|
|
|
expect(subject.hidden?).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if direct_visibility?' do
|
|
|
|
it 'returns true' do
|
|
|
|
subject.visibility = :direct
|
|
|
|
expect(subject.hidden?).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if public_visibility?' do
|
|
|
|
it 'returns false' do
|
|
|
|
subject.visibility = :public
|
|
|
|
expect(subject.hidden?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if unlisted_visibility?' do
|
|
|
|
it 'returns false' do
|
|
|
|
subject.visibility = :unlisted
|
|
|
|
expect(subject.hidden?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-02-26 08:28:08 -06:00
|
|
|
describe '#content' do
|
|
|
|
it 'returns the text of the status if it is not a reblog' do
|
|
|
|
expect(subject.content).to eql subject.text
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the text of the reblogged status' do
|
|
|
|
subject.reblog = other
|
|
|
|
expect(subject.content).to eql other.text
|
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#target' do
|
2016-02-26 08:28:08 -06:00
|
|
|
it 'returns nil if the status is self-contained' do
|
2018-10-07 21:50:11 -05:00
|
|
|
expect(subject.target).to be_nil
|
2016-02-26 08:28:08 -06:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nil if the status is a reply' do
|
|
|
|
subject.thread = other
|
|
|
|
expect(subject.target).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the reblogged status' do
|
|
|
|
subject.reblog = other
|
|
|
|
expect(subject.target).to eq other
|
|
|
|
end
|
2016-02-24 17:17:01 -06:00
|
|
|
end
|
2016-03-19 06:13:47 -05:00
|
|
|
|
|
|
|
describe '#reblogs_count' do
|
2017-04-07 14:30:36 -05:00
|
|
|
it 'is the number of reblogs' do
|
|
|
|
Fabricate(:status, account: bob, reblog: subject)
|
|
|
|
Fabricate(:status, account: alice, reblog: subject)
|
|
|
|
|
|
|
|
expect(subject.reblogs_count).to eq 2
|
|
|
|
end
|
2018-05-29 19:50:23 -05:00
|
|
|
|
|
|
|
it 'is decremented when reblog is removed' do
|
|
|
|
reblog = Fabricate(:status, account: bob, reblog: subject)
|
|
|
|
expect(subject.reblogs_count).to eq 1
|
|
|
|
reblog.destroy
|
|
|
|
expect(subject.reblogs_count).to eq 0
|
|
|
|
end
|
2018-08-17 20:03:23 -05:00
|
|
|
|
|
|
|
it 'does not fail when original is deleted before reblog' do
|
|
|
|
reblog = Fabricate(:status, account: bob, reblog: subject)
|
|
|
|
expect(subject.reblogs_count).to eq 1
|
|
|
|
expect { subject.destroy }.to_not raise_error
|
|
|
|
expect(Status.find_by(id: reblog.id)).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#replies_count' do
|
|
|
|
it 'is the number of replies' do
|
|
|
|
reply = Fabricate(:status, account: bob, thread: subject)
|
|
|
|
expect(subject.replies_count).to eq 1
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is decremented when reply is removed' do
|
|
|
|
reply = Fabricate(:status, account: bob, thread: subject)
|
|
|
|
expect(subject.replies_count).to eq 1
|
|
|
|
reply.destroy
|
|
|
|
expect(subject.replies_count).to eq 0
|
|
|
|
end
|
2016-03-19 06:13:47 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#favourites_count' do
|
2017-04-07 14:30:36 -05:00
|
|
|
it 'is the number of favorites' do
|
|
|
|
Fabricate(:favourite, account: bob, status: subject)
|
|
|
|
Fabricate(:favourite, account: alice, status: subject)
|
|
|
|
|
|
|
|
expect(subject.favourites_count).to eq 2
|
|
|
|
end
|
2018-05-29 19:50:23 -05:00
|
|
|
|
|
|
|
it 'is decremented when favourite is removed' do
|
|
|
|
favourite = Fabricate(:favourite, account: bob, status: subject)
|
|
|
|
expect(subject.favourites_count).to eq 1
|
|
|
|
favourite.destroy
|
|
|
|
expect(subject.favourites_count).to eq 0
|
|
|
|
end
|
2016-03-19 06:13:47 -05:00
|
|
|
end
|
2017-04-07 13:18:30 -05:00
|
|
|
|
|
|
|
describe '#proper' do
|
|
|
|
it 'is itself for original statuses' do
|
|
|
|
expect(subject.proper).to eq subject
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is the source status for reblogs' do
|
|
|
|
subject.reblog = other
|
|
|
|
expect(subject.proper).to eq other
|
|
|
|
end
|
|
|
|
end
|
2017-04-24 15:37:24 -05:00
|
|
|
|
2017-12-14 02:27:42 -06:00
|
|
|
describe 'on create' do
|
|
|
|
let(:local_account) { Fabricate(:account, username: 'local', domain: nil) }
|
|
|
|
let(:remote_account) { Fabricate(:account, username: 'remote', domain: 'example.com') }
|
|
|
|
|
|
|
|
subject { Status.new }
|
|
|
|
|
|
|
|
describe 'on a status that ends with the local-only emoji' do
|
|
|
|
before do
|
|
|
|
subject.text = 'A toot ' + subject.local_only_emoji
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if the status originates from this instance' do
|
|
|
|
before do
|
|
|
|
subject.account = local_account
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is marked local-only' do
|
|
|
|
subject.save!
|
|
|
|
|
|
|
|
expect(subject).to be_local_only
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if the status is remote' do
|
|
|
|
before do
|
|
|
|
subject.account = remote_account
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not marked local-only' do
|
|
|
|
subject.save!
|
|
|
|
|
|
|
|
expect(subject).to_not be_local_only
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Feature conversations muting (#3017)
* Add <ostatus:conversation /> tag to Atom input/output
Only uses ref attribute (not href) because href would be
the alternate link that's always included also.
Creates new conversation for every non-reply status. Carries
over conversation for every reply. Keeps remote URIs verbatim,
generates local URIs on the fly like the rest of them.
* Conversation muting - prevents notifications that reference a conversation
(including replies, favourites, reblogs) from being created. API endpoints
/api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute
Currently no way to tell when a status/conversation is muted, so the web UI
only has a "disable notifications" button, doesn't work as a toggle
* Display "Dismiss notifications" on all statuses in notifications column, not just own
* Add "muted" as a boolean attribute on statuses JSON
For now always false on contained reblogs, since it's only relevant for
statuses returned from the notifications endpoint, which are not nested
Remove "Disable notifications" from detailed status view, since it's
only relevant in the notifications column
* Up max class length
* Remove pending test for conversation mute
* Add tests, clean up
* Rename to "mute conversation" and "unmute conversation"
* Raise validation error when trying to mute/unmute status without conversation
2017-05-14 20:04:13 -05:00
|
|
|
describe '.mutes_map' do
|
|
|
|
let(:status) { Fabricate(:status) }
|
|
|
|
let(:account) { Fabricate(:account) }
|
|
|
|
|
|
|
|
subject { Status.mutes_map([status.conversation.id], account) }
|
|
|
|
|
|
|
|
it 'returns a hash' do
|
|
|
|
expect(subject).to be_a Hash
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains true value' do
|
|
|
|
account.mute_conversation!(status.conversation)
|
|
|
|
expect(subject[status.conversation.id]).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.favourites_map' do
|
|
|
|
let(:status) { Fabricate(:status) }
|
|
|
|
let(:account) { Fabricate(:account) }
|
|
|
|
|
|
|
|
subject { Status.favourites_map([status], account) }
|
|
|
|
|
|
|
|
it 'returns a hash' do
|
|
|
|
expect(subject).to be_a Hash
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains true value' do
|
|
|
|
Fabricate(:favourite, status: status, account: account)
|
|
|
|
expect(subject[status.id]).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.reblogs_map' do
|
|
|
|
let(:status) { Fabricate(:status) }
|
|
|
|
let(:account) { Fabricate(:account) }
|
|
|
|
|
|
|
|
subject { Status.reblogs_map([status], account) }
|
|
|
|
|
|
|
|
it 'returns a hash' do
|
|
|
|
expect(subject).to be_a Hash
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains true value' do
|
|
|
|
Fabricate(:status, account: account, reblog: status)
|
|
|
|
expect(subject[status.id]).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-17 06:54:02 -05:00
|
|
|
describe '.in_chosen_languages' do
|
2017-09-22 12:33:17 -05:00
|
|
|
context 'for accounts with language filters' do
|
2018-06-17 06:54:02 -05:00
|
|
|
let(:user) { Fabricate(:user, chosen_languages: ['en']) }
|
2017-09-22 12:33:17 -05:00
|
|
|
|
2018-06-17 06:54:02 -05:00
|
|
|
it 'does not include statuses in not in chosen languages' do
|
|
|
|
status = Fabricate(:status, language: 'de')
|
|
|
|
expect(Status.in_chosen_languages(user.account)).not_to include status
|
2017-09-22 12:33:17 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes status with unknown language' do
|
|
|
|
status = Fabricate(:status, language: nil)
|
2018-06-17 06:54:02 -05:00
|
|
|
expect(Status.in_chosen_languages(user.account)).to include status
|
2017-09-22 12:33:17 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-10-15 23:02:39 -05:00
|
|
|
describe '.as_direct_timeline' do
|
|
|
|
let(:account) { Fabricate(:account) }
|
|
|
|
let(:followed) { Fabricate(:account) }
|
|
|
|
let(:not_followed) { Fabricate(:account) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
Fabricate(:follow, account: account, target_account: followed)
|
|
|
|
|
|
|
|
@self_public_status = Fabricate(:status, account: account, visibility: :public)
|
|
|
|
@self_direct_status = Fabricate(:status, account: account, visibility: :direct)
|
|
|
|
@followed_public_status = Fabricate(:status, account: followed, visibility: :public)
|
|
|
|
@followed_direct_status = Fabricate(:status, account: followed, visibility: :direct)
|
|
|
|
@not_followed_direct_status = Fabricate(:status, account: not_followed, visibility: :direct)
|
|
|
|
|
|
|
|
@results = Status.as_direct_timeline(account)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include public statuses from self' do
|
|
|
|
expect(@results).to_not include(@self_public_status)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes direct statuses from self' do
|
|
|
|
expect(@results).to include(@self_direct_status)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include public statuses from followed' do
|
|
|
|
expect(@results).to_not include(@followed_public_status)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include direct statuses not mentioning recipient from followed' do
|
|
|
|
expect(@results).to_not include(@followed_direct_status)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include direct statuses not mentioning recipient from non-followed' do
|
|
|
|
expect(@results).to_not include(@not_followed_direct_status)
|
|
|
|
end
|
|
|
|
|
2018-05-28 04:04:06 -05:00
|
|
|
it 'includes direct statuses mentioning recipient from followed' do
|
|
|
|
Fabricate(:mention, account: account, status: @followed_direct_status)
|
|
|
|
results2 = Status.as_direct_timeline(account)
|
|
|
|
expect(results2).to include(@followed_direct_status)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes direct statuses mentioning recipient from non-followed' do
|
|
|
|
Fabricate(:mention, account: account, status: @not_followed_direct_status)
|
|
|
|
results2 = Status.as_direct_timeline(account)
|
|
|
|
expect(results2).to include(@not_followed_direct_status)
|
|
|
|
end
|
2017-10-15 23:02:39 -05:00
|
|
|
end
|
|
|
|
|
2017-05-15 19:54:17 -05:00
|
|
|
describe '.permitted_for' do
|
|
|
|
subject { described_class.permitted_for(target_account, account).pluck(:visibility) }
|
|
|
|
|
|
|
|
let(:target_account) { alice }
|
|
|
|
let(:account) { bob }
|
|
|
|
let!(:public_status) { Fabricate(:status, account: target_account, visibility: 'public') }
|
|
|
|
let!(:unlisted_status) { Fabricate(:status, account: target_account, visibility: 'unlisted') }
|
|
|
|
let!(:private_status) { Fabricate(:status, account: target_account, visibility: 'private') }
|
|
|
|
|
|
|
|
let!(:direct_status) do
|
|
|
|
Fabricate(:status, account: target_account, visibility: 'direct').tap do |status|
|
|
|
|
Fabricate(:mention, status: status, account: account)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
let!(:other_direct_status) do
|
|
|
|
Fabricate(:status, account: target_account, visibility: 'direct').tap do |status|
|
|
|
|
Fabricate(:mention, status: status)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'given nil' do
|
|
|
|
let(:account) { nil }
|
|
|
|
let(:direct_status) { nil }
|
|
|
|
it { is_expected.to eq(%w(unlisted public)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'given blocked account' do
|
|
|
|
before do
|
|
|
|
target_account.block!(account)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'given same account' do
|
|
|
|
let(:account) { target_account }
|
|
|
|
it { is_expected.to eq(%w(direct direct private unlisted public)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'given followed account' do
|
|
|
|
before do
|
|
|
|
account.follow!(target_account)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(%w(direct private unlisted public)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'given unfollowed account' do
|
|
|
|
it { is_expected.to eq(%w(direct unlisted public)) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 12:01:28 -05:00
|
|
|
describe 'before_validation' do
|
2017-05-12 12:09:21 -05:00
|
|
|
it 'sets account being replied to correctly over intermediary nodes' do
|
|
|
|
first_status = Fabricate(:status, account: bob)
|
|
|
|
intermediary = Fabricate(:status, thread: first_status, account: alice)
|
|
|
|
final = Fabricate(:status, thread: intermediary, account: alice)
|
|
|
|
|
|
|
|
expect(final.in_reply_to_account_id).to eq bob.id
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates new conversation for stand-alone status' do
|
|
|
|
expect(Status.create(account: alice, text: 'First').conversation_id).to_not be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'keeps conversation of parent node' do
|
|
|
|
parent = Fabricate(:status, text: 'First')
|
|
|
|
expect(Status.create(account: alice, thread: parent, text: 'Response').conversation_id).to eq parent.conversation_id
|
|
|
|
end
|
2017-09-06 12:01:28 -05:00
|
|
|
|
|
|
|
it 'sets `local` to true for status by local account' do
|
|
|
|
expect(Status.create(account: alice, text: 'foo').local).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets `local` to false for status by remote account' do
|
|
|
|
alice.update(domain: 'example.com')
|
|
|
|
expect(Status.create(account: alice, text: 'foo').local).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-17 08:21:57 -05:00
|
|
|
describe 'validation' do
|
|
|
|
it 'disallow empty uri for remote status' do
|
|
|
|
alice.update(domain: 'example.com')
|
|
|
|
status = Fabricate.build(:status, uri: '', account: alice)
|
|
|
|
expect(status).to model_have_error_on_field(:uri)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 12:01:28 -05:00
|
|
|
describe 'after_create' do
|
|
|
|
it 'saves ActivityPub uri as uri for local status' do
|
|
|
|
status = Status.create(account: alice, text: 'foo')
|
|
|
|
status.reload
|
|
|
|
expect(status.uri).to start_with('https://')
|
|
|
|
end
|
2017-05-12 12:09:21 -05:00
|
|
|
end
|
2016-02-20 15:53:20 -06:00
|
|
|
end
|